]> Cypherpunks repositories - gostls13.git/commit
runtime: fix hashing of trace stacks
authorAustin Clements <austin@google.com>
Thu, 13 Aug 2015 03:39:10 +0000 (23:39 -0400)
committerAustin Clements <austin@google.com>
Mon, 14 Sep 2015 18:14:14 +0000 (18:14 +0000)
commit739f13383791847fd4b0a1eab7e333b5780be039
tree4ec64a45e2a3dfb2bd731ddce98bb05434c44b69
parentb9dbb030d5e7d2733e877972568368dc806b7304
runtime: fix hashing of trace stacks

The call to hash the trace stack reversed the "seed" and "size"
arguments to memhash and, hence, always called memhash with a 0 size,
which dutifully returned a hash value that depended only on the number
of PCs in the stack and not their values. As a result, all stacks were
put in to a very subset of the 8,192 buckets.

Fix this by passing these arguments in the correct order.

Change-Id: I67cd29312f5615c7ffa23e205008dd72c6b8af62
Reviewed-on: https://go-review.googlesource.com/13613
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
src/runtime/trace.go