]> Cypherpunks repositories - gostls13.git/commit
net: skip external net tests on iOS
authorElias Naur <elias.naur@gmail.com>
Thu, 17 May 2018 13:20:57 +0000 (15:20 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 17 May 2018 14:27:12 +0000 (14:27 +0000)
commit74604bb517b8615331aae44166e0368b25f6a4cb
tree60decbe95b36a33ff876ede0330a29b115b3f0d9
parent67894aa7e20cc57bfe0acb289efc1671263f439d
net: skip external net tests on iOS

CL 113095 tried to deflake net tests on iOS by skipping the test
that uses the most sockets. That didn't work well enough and will
be reverted in CL 113555.

The flakes appeared after the iOS exec harness started to forward
environment variables, causing testenv.Builder to be non-empty on
the iOS builder. This CL attempts to fix the flakes with the more
conservative strategy of skipping tests that only run on builders.

The skipped tests happen to be those requiring external network
access; it's plausible that the iOS builder network isn't reliable
enough to run the many parallel DNS lookups and dial outs, while
keeping the number of open file descriptors below the 250 limit.

Change-Id: I9cafdaf2845dd6f3844c4819dcaaaa5970f5da15
Reviewed-on: https://go-review.googlesource.com/113575
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/dial_test.go
src/net/lookup_test.go
src/net/tcpsock_unix_test.go