]> Cypherpunks repositories - gostls13.git/commit
runtime: check gdb exit status and log output
authorMichael Pratt <mpratt@google.com>
Tue, 26 May 2020 19:55:54 +0000 (15:55 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 27 May 2020 15:53:56 +0000 (15:53 +0000)
commit748533e3a1a8e64b3910b9cac1e767d95ee38f84
treec8a56ad0b89a7f40e624049617a8e9c783489a22
parent902d8de79ed9bb6013cdb1952db1538bc1d10677
runtime: check gdb exit status and log output

All GDB tests currently ignore non-zero exit statuses. When tests
flakes, we don't even know if GDB exited successfully or not.

Add checks for non-zero exits, which are not expected.

Furthermore, always log the output from GDB. The tests are currently
inconsistent about whether they always log, or only on error.

Updates #39021

Change-Id: I7af1d795fc2fdf58093cb2731d616d4aa44e9996
Reviewed-on: https://go-review.googlesource.com/c/go/+/235282
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/runtime-gdb_test.go