]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/moddeps: use a temporary directory for GOMODCACHE if needed
authorBryan C. Mills <bcmills@google.com>
Wed, 16 Jun 2021 20:33:29 +0000 (16:33 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 21 Jun 2021 20:53:11 +0000 (20:53 +0000)
commit761edf71f64bb2ef949ceb588822c47d2e1cc6ac
treed2dbeee69226d81561bf3830662df79074ffed37
parenta0400420ade001265f656c5dd9be1b48d7c8e6fe
cmd/internal/moddeps: use a temporary directory for GOMODCACHE if needed

CL 328770 should be sufficient to fix the specific failure in the
report, but when attempting to reproduce it I noticed a related
failure mode, triggered by the environment variables set in
src/run.bash.

The failure mode is currently masked on the Go project builders due to
the lack of any 'longtest' builder running as a non-root user
(#10719).

It is also masked from Go contributors running 'run.bash' locally
because 'run.bash' does not actually run all of the tests unless
GO_TEST_SHORT=0 is set in the environment (#29266, #46054).

Fixes #46695

Change-Id: I272c09dae462734590dce59b3d3c5b6d3f733c92
Reviewed-on: https://go-review.googlesource.com/c/go/+/328771
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/internal/moddeps/moddeps_test.go