]> Cypherpunks repositories - gostls13.git/commit
compress/flate: revert a goto for-loop
authorDaniel Martí <mvdan@mvdan.cc>
Fri, 16 Oct 2020 14:05:04 +0000 (15:05 +0100)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 16 Oct 2020 14:23:21 +0000 (14:23 +0000)
commit771f5f2e487db4eb2bcf6fa1660dc8cef1feaf14
tree6ff610c77a01baf1c44c512194fa377357214cb5
parent8ee4d6e1bf1e76a4eac627d5fc9b0d0332d209e2
compress/flate: revert a goto for-loop

In https://golang.org/cl/16528, a goto loop was chosen over a regular
for loop since that would make the function inlinable.

Thanks to the recent https://golang.org/cl/256459, for loops without a
label can now be inlined. So we can undo the workaround and simplify the
code.

Also add the function to TestIntendedInlining, which passes both before
and after the change, as expected.

For #14768.

Change-Id: Ie5df55a6bcb07c538ca331eef2f908807ff0b516
Reviewed-on: https://go-review.googlesource.com/c/go/+/263037
Trust: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/cmd/compile/internal/gc/inl_test.go
src/compress/flate/dict_decoder.go