]> Cypherpunks repositories - gostls13.git/commit
runtime: check that stack barrier unwind is in sync
authorAustin Clements <austin@google.com>
Wed, 26 Aug 2015 19:06:43 +0000 (15:06 -0400)
committerAustin Clements <austin@google.com>
Sun, 30 Aug 2015 16:07:02 +0000 (16:07 +0000)
commit77e528293bbb51a92d16a5e77a8d7920c96764bd
tree8ab0cea7202ec223cc3bddfad34002f674dfd413
parent3bfc9df21aefe486de2c8a620a36fac178650a8c
runtime: check that stack barrier unwind is in sync

Currently the stack barrier stub blindly unwinds the next stack
barrier from the G's stack barrier array without checking that it's
the right stack barrier. If through some bug the stack barrier array
position gets out of sync with where we actually are on the stack,
this could return to the wrong PC, which would lead to difficult to
debug crashes. To address this, this commit adds a check to the amd64
stack barrier stub that it's unwinding the correct stack barrier.

Updates #12238.

Change-Id: If824d95191d07e2512dc5dba0d9978cfd9f54e02
Reviewed-on: https://go-review.googlesource.com/13948
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/asm_amd64.s