]> Cypherpunks repositories - gostls13.git/commit
cmd/cgo/internal/swig: force use of lld for LTO tests on the builders
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 30 May 2024 03:36:41 +0000 (03:36 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 30 May 2024 12:38:14 +0000 (12:38 +0000)
commit787414ca488dbb819b1ec82ff5d620b32e79de37
treeda253792310e4bdcb5e30cd15667b718502cc741
parent1cf862e66c6e65217c1254a7bfac6f3e77f4ae23
cmd/cgo/internal/swig: force use of lld for LTO tests on the builders

For whatever reason, on the builders, when using /usr/bin/ld (the
default linker) with -flto we end up with problems. Specifically, the
linker seems to require LLVMgold.so and can't find it. I'm not really
sure why, but what definitely seems to work is forcing use of lld, which
ships with our clang installation on the builders.

Just enforce this on the builders for now; I've actually had very few
problems running this locally (and I think I'm also mixing and matching
linkers and toolchains too...), so it may be related to the version of
clang we're testing with.

This change, along with CL 589295, should fully fix the clang builders.

Fixes #67698.

Change-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-clang15,gotip-linux-386-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/589296
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/cgo/internal/swig/swig_test.go