]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/compile: replace Type.OrigSym with Type.OrigType
authorMatthew Dempsky <mdempsky@google.com>
Mon, 21 Mar 2022 17:06:48 +0000 (10:06 -0700)
committerCherry Mui <cherryyz@google.com>
Mon, 4 Apr 2022 20:26:50 +0000 (20:26 +0000)
commit78b8b4a1760ce212c05edd14f52711936ee60930
treee165d4e7a9aa4323a364a97abd89d87cb4ea6808
parent6ebf6762896edf0d33873433f0fcaf7e4a418539
[release-branch.go1.18] cmd/compile: replace Type.OrigSym with Type.OrigType

First law of cmd/compile frontend development: thou shalt not rely on
types.Sym.

This CL replaces Type.OrigSym with Type.OrigType, which semantically
matches what all of the uses within the frontend actually care about,
and avoids using types.Sym, which invariably leads to mistakes because
symbol scoping in the frontend doesn't work how anyone intuitively
expects it to.

Fixes #51855.

Change-Id: I4affe6ee0718103ce5006ab68aa7e1bb0cac6881
Reviewed-on: https://go-review.googlesource.com/c/go/+/394274
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit adae6ec542c3287ffe643093a0f61c9871f4e238)
Reviewed-on: https://go-review.googlesource.com/c/go/+/394296
src/cmd/compile/internal/noder/decl.go
src/cmd/compile/internal/noder/stencil.go
src/cmd/compile/internal/noder/types.go
src/cmd/compile/internal/reflectdata/reflect.go
src/cmd/compile/internal/typecheck/crawler.go
src/cmd/compile/internal/typecheck/iexport.go
src/cmd/compile/internal/typecheck/iimport.go
src/cmd/compile/internal/typecheck/subr.go
src/cmd/compile/internal/types/type.go
test/typeparam/issue51765.go [new file with mode: 0644]