]> Cypherpunks repositories - gostls13.git/commit
misc/cgo/errors: consolidate test work
authorRuss Cox <rsc@golang.org>
Thu, 16 May 2019 14:00:10 +0000 (10:00 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 21 May 2019 18:15:05 +0000 (18:15 +0000)
commit798e0b38ed8b23da010b1a8cd6c91f201248e40d
treee8b67e99c0997e11c6354d1964e6038bffafe216
parentb8648184941815d1466b09071e2907323b9283c6
misc/cgo/errors: consolidate test work

Build a single binary containing all the TestPointerChecks
instead of building many small binaries,
each with its own cgo+compile+link invocation.
This cuts 'go test -run=TestPointerChecks'
from 6.7r 35.5u 26.1s to 2.1r 2.1u 1.4s.

Move as many cgo checks as possible into fewer test files
for TestReportsTypeErrors too.
This cuts 'go test -run=TestReportsTypeErrors'
from 2.1r 6.7u 6.7s to 1.5r 2.5u 2.5s.

After this change, all.bash runs in ~4:30 on my laptop.

For #26473.

Change-Id: I3787448b03689a1f62dd810957ab6013bb75582f
Reviewed-on: https://go-review.googlesource.com/c/go/+/177599
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
15 files changed:
misc/cgo/errors/errors_test.go
misc/cgo/errors/ptr_test.go
misc/cgo/errors/testdata/err1.go
misc/cgo/errors/testdata/err2.go
misc/cgo/errors/testdata/err3.go [deleted file]
misc/cgo/errors/testdata/issue13129.go [deleted file]
misc/cgo/errors/testdata/issue13423.go [deleted file]
misc/cgo/errors/testdata/issue13467.go [deleted file]
misc/cgo/errors/testdata/issue13635.go [deleted file]
misc/cgo/errors/testdata/issue13830.go [deleted file]
misc/cgo/errors/testdata/issue16116.go [deleted file]
misc/cgo/errors/testdata/issue16591.go [deleted file]
misc/cgo/errors/testdata/issue26745.go [deleted file]
misc/cgo/errors/testdata/issue7757.go [deleted file]
misc/cgo/errors/testdata/issue8442.go [deleted file]