]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: lazily create true and false Values in shortcircuit
authorJosh Bleecher Snyder <josharian@gmail.com>
Sun, 23 Apr 2017 12:03:11 +0000 (05:03 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Mon, 24 Apr 2017 00:58:27 +0000 (00:58 +0000)
commit79e5ef293545dd4f96b10e0bf82582e5dd57757a
tree523f8955d233939a9bb8da2acefad5b3f6d8f31c
parent976a5ce1a86bfb3772f1301a77eb41c17fe9178a
cmd/compile: lazily create true and false Values in shortcircuit

It is mildly wasteful to always create values
that must sometimes then be dead code eliminated.
Given that it is very easy to avoid, do so.

Noticed when examining a package with thousands
of generated wrappers, each of which uses
only a handful of Values to compile.

Change-Id: If02eb4aa786dfa20f7aa43e8d729dad8b3db2786
Reviewed-on: https://go-review.googlesource.com/41502
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/ssa/shortcircuit.go