]> Cypherpunks repositories - gostls13.git/commit
misc/ios: don't override GOCACHE on the device
authorElias Naur <mail@eliasnaur.com>
Thu, 21 Mar 2019 14:15:40 +0000 (15:15 +0100)
committerElias Naur <mail@eliasnaur.com>
Thu, 21 Mar 2019 16:24:05 +0000 (16:24 +0000)
commit7ae8e53de293dd567c1d02dec679f67381c9ace5
treec5fe4bdfeee89376691a385a2b93d0380e2ca9de
parent409c97c5f017037e3a47aff64e3e65ce22eee5ba
misc/ios: don't override GOCACHE on the device

The iOS exec wrapper copies the environment variables to the binary
running on the device. However, some variables such as HOME, TMPDIR and
GOCACHE refer to directories that might not be valid on the device.

The wrapper already ignores HOME and TMPDIR, but after GO111MODULE
was flipped to on for the standard library, cmd/go tests started
failing without a valid and writable GOCACHE.

It took a while to reproduce because go test does not set an explicit
GOCACHE but cmd/dist test does.

Fixes #30914

Change-Id: If186cddc5cfd7ad39a0b3eb95f9c64a7d53a27e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/168557
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
misc/ios/go_darwin_arm_exec.go