]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: fix bogo IgnoreClientVersionOrder skip reason
authorDaniel McCarney <daniel@binaryparadox.net>
Fri, 9 May 2025 14:29:47 +0000 (10:29 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 16 May 2025 03:14:22 +0000 (20:14 -0700)
commit7b4a3d93d7783e2c4593e604bedc6ffda64f2225
tree3e7fce3ac24d33dd3a5e7b1401bed225608e398a
parentd681270714bc91b28a2cd97c3eae138b3112ff1d
crypto/tls: fix bogo IgnoreClientVersionOrder skip reason

The BoGo IgnoreClientVersionOrder test checks that a client that sends
a supported_versions extension with the list [TLS 1.2, TLS 1.3] ends up
negotiating TLS 1.3.

However, the crypto/tls module treats this list as being in client
preference order, and so negotiates TLS 1.2, failing the test.

Our behaviour appears to be the correct handling based on RFC 8446
ยง4.2.1 where it says:
  The extension contains a list of supported versions in preference
  order, with the most preferred version first.

This commit updates the reason we skip this test to cite the RFC instead
of saying it's something to be fixed.

Updates #72006
Change-Id: I27a2cd231e4b8762b0d9e2dbd3d8ddd5b87fd5ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/671415
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Daniel McCarney <daniel@binaryparadox.net>
src/crypto/tls/bogo_config.json