]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: remove var sorting from DWARF inline generation
authorThan McIntosh <thanm@google.com>
Tue, 28 Aug 2018 15:27:07 +0000 (11:27 -0400)
committerThan McIntosh <thanm@google.com>
Wed, 29 Aug 2018 11:30:44 +0000 (11:30 +0000)
commit7b88b22acf8cb5e32f34e2a396d797c5c0125566
treee43ac2689568b902a598855b74617e824329be44
parent225981f8e78b6755bbe34c2e5d035a534ed1b25d
cmd/compile: remove var sorting from DWARF inline generation

When generation DWARF inline info records, the current implementation
includes a sorting pass that reorders a subprogram's child variable
DIEs based on class (param/auto) and name. This sorting is no longer
needed, and can cause problems for a debugger (if we want to use the
DWARF info for creating a call to an optimized function); this patch
removes it.

Ordering of DWARF subprogram variable/parameter DIEs is still
deterministic with this change, since it is keyed off the order in
which vars appear in the pre-inlining function "Dcl" list.

Updates #27039

Change-Id: I3b91290d11bb3b9b36fb61271d80b801841401ee
Reviewed-on: https://go-review.googlesource.com/131895
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/compile/internal/gc/dwinl.go
src/cmd/compile/internal/gc/pgen.go