]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: clarify documentation on tls.Config.NextProtos
authorPontus Leitzler <leitzler@users.noreply.github.com>
Tue, 30 Oct 2018 07:58:59 +0000 (07:58 +0000)
committerFilippo Valsorda <filippo@golang.org>
Tue, 30 Oct 2018 15:07:42 +0000 (15:07 +0000)
commit7bada2cf4676938be46cde13e2b8e11e42b5441c
tree999137675e80ceb9402e263adda0630cfa2e947c
parent455ef3f6bce369bf6a91b181cbd9ef689c850c5d
crypto/tls: clarify documentation on tls.Config.NextProtos

This change will aid users to make less mistakes where you, for example, define both HTTP/1.1 and H2, but in the wrong order.

    package main

    import (
        "crypto/tls"
        "net"
    )

    func main() {
        srv := &http.Server{
            TLSConfig: &tls.Config{
                NextProtos: []string{"http/1.1", "h2"},
            },
        }
        srv.ListenAndServeTLS("server.crt", "server.key")
    }

When using major browsers or curl, they will never be served H2 since they also support HTTP/1.0 and the list is processed in order.

Change-Id: Id14098b5e48f624ca308137917874d475c2f22a0
GitHub-Last-Rev: f3594a6411bf7dde71c850f3e85a2b5a21974129
GitHub-Pull-Request: golang/go#28367
Reviewed-on: https://go-review.googlesource.com/c/144387
Reviewed-by: Filippo Valsorda <filippo@golang.org>
src/crypto/tls/common.go