]> Cypherpunks repositories - gostls13.git/commit
bytes/hash: disable seed test on 32-bit platforms
authorKeith Randall <khr@google.com>
Tue, 3 Sep 2019 17:27:48 +0000 (10:27 -0700)
committerKeith Randall <khr@golang.org>
Tue, 3 Sep 2019 19:37:16 +0000 (19:37 +0000)
commit7c90e2cbda677a1a9993403df192f31fb011a112
treed7a2efef3e60dab6c7cfe55a8594961805933f1e
parentd2f958d8d11bcf62fe572885133bfaef41307a14
bytes/hash: disable seed test on 32-bit platforms

The distribution of hash outputs when varying the seed is
not good enough on 32-bit platforms.

This isn't a likely attack vector (the adversary controlling the seed),
so it isn't a huge deal. Would be nice to fix, though. For now, just
skip this test.

Fixes #33988

Change-Id: Icf51ab687fc215422a5492ae78e6f414b33e04cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/193078
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/bytes/hash/smhasher_test.go