]> Cypherpunks repositories - gostls13.git/commit
runtime: always report starting heap size in gctrace
authorAustin Clements <austin@google.com>
Tue, 21 Jul 2015 15:38:14 +0000 (11:38 -0400)
committerAustin Clements <austin@google.com>
Mon, 27 Jul 2015 17:45:28 +0000 (17:45 +0000)
commit7eeeae2a5cc5087347c2fcdfc9731c87143dab4a
treeb4311fca5ece779b41b9d230f338a4383a9ba3ab
parentcc6ed285e58be9c3c16ab2f2bc34d61687dfc3ff
runtime: always report starting heap size in gctrace

Currently the gctrace output reports the trigger heap size, rather
than the actual heap size at the beginning of GC. Often these are the
same, or at least very close. However, it's possible for the heap to
already have exceeded this trigger when we first check the trigger and
start GC; in this case, this output is very misleading. We've
encountered this confusion a few times when debugging and this
behavior is difficult to document succinctly.

Change the gctrace output to report the actual heap size when GC
starts, rather than the trigger.

Change-Id: I246b3ccae4c4c7ea44c012e70d24a46878d7601f
Reviewed-on: https://go-review.googlesource.com/12452
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/mgc.go