]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: insert scheduling checks on loop backedges
authorDavid Chase <drchase@google.com>
Thu, 10 Nov 2016 21:03:47 +0000 (16:03 -0500)
committerDavid Chase <drchase@google.com>
Mon, 9 Jan 2017 21:01:29 +0000 (21:01 +0000)
commit7f1ff65c3947b916cc4d0827fd8c1307d7efd7bf
treea9b8ff06dd46b39671df2649f42d5b3f8551bafa
parentf412bd31ce1859ea1dd0d46ec1b130c44b480115
cmd/compile: insert scheduling checks on loop backedges

Loop breaking with a counter.  Benchmarked (see comments),
eyeball checked for sanity on popular loops.  This code
ought to handle loops in general, and properly inserts phi
functions in cases where the earlier version might not have.

Includes test, plus modifications to test/run.go to deal with
timeout and killing looping test.  Tests broken by the addition
of extra code (branch frequency and live vars) for added
checks turn the check insertion off.

If GOEXPERIMENT=preemptibleloops, the compiler inserts reschedule
checks on every backedge of every reducible loop.  Alternately,
specifying GO_GCFLAGS=-d=ssa/insert_resched_checks/on will
enable it for a single compilation, but because the core Go
libraries contain some loops that may run long, this is less
likely to have the desired effect.

This is intended as a tool to help in the study and diagnosis
of GC and other latency problems, now that goal STW GC latency
is on the order of 100 microseconds or less.

Updates #17831.
Updates #10958.

Change-Id: I6206c163a5b0248e3f21eb4fc65f73a179e1f639
Reviewed-on: https://go-review.googlesource.com/33910
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
13 files changed:
src/cmd/compile/internal/gc/builtin.go
src/cmd/compile/internal/gc/builtin/runtime.go
src/cmd/compile/internal/gc/ssa.go
src/cmd/compile/internal/ssa/compile.go
src/cmd/compile/internal/ssa/func.go
src/cmd/compile/internal/ssa/loopreschedchecks.go [new file with mode: 0644]
src/cmd/compile/internal/ssa/sparsetree.go
src/cmd/internal/obj/go.go
src/runtime/proc.go
test/fixedbugs/issue10958.go [new file with mode: 0644]
test/live.go
test/opt_branchlikely.go
test/run.go