]> Cypherpunks repositories - gostls13.git/commit
build: enable framepointer mode by default
authorRuss Cox <rsc@golang.org>
Wed, 25 May 2016 18:37:43 +0000 (14:37 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 26 May 2016 19:02:00 +0000 (19:02 +0000)
commit7fdec6216c0a25c6dbcc8159b755da6682dd9080
treebf489c761706e04d64ef73675ceb805c4b30a3c4
parent2168f2a68bb438996d14869ff7dd10a47cc0552c
build: enable framepointer mode by default

This has a minor performance cost, but far less than is being gained by SSA.
As an experiment, enable it during the Go 1.7 beta.
Having frame pointers on by default makes Linux's perf, Intel VTune,
and other profilers much more useful, because it lets them gather a
stack trace efficiently on profiling events.
(It doesn't help us that much, since when we walk the stack we usually
need to look up PC-specific information as well.)

Fixes #15840.

Change-Id: I4efd38412a0de4a9c87b1b6e5d11c301e63f1a2a
Reviewed-on: https://go-review.googlesource.com/23451
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
13 files changed:
src/cmd/compile/internal/amd64/galign.go
src/cmd/compile/internal/amd64/reg.go
src/cmd/compile/internal/ssa/regalloc.go
src/cmd/internal/obj/go.go
src/cmd/internal/obj/link.go
src/cmd/internal/obj/sym.go
src/cmd/internal/obj/x86/asm6.go
src/cmd/internal/obj/x86/obj6.go
src/cmd/link/internal/ld/dwarf.go
src/cmd/link/internal/ld/lib.go
src/runtime/proc.go
src/runtime/runtime2.go
src/runtime/stack.go