]> Cypherpunks repositories - gostls13.git/commit
syscall: clarify which handles are affected by SysProcAttr.NoInheritHandles
authorqmuntal <quimmuntal@gmail.com>
Fri, 23 Jun 2023 10:44:15 +0000 (12:44 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Tue, 27 Jun 2023 16:16:24 +0000 (16:16 +0000)
commit8008c0840ff09c492434e67de443ee478957fb8f
treed9e208f6db98e8d0e6ba15c6ee22251f80782baa
parent13529cc5f443ef4e242da3716daa0032aa8d34f2
syscall: clarify which handles are affected by SysProcAttr.NoInheritHandles

SysProcAttr.NoInheritHandles doc comment is not clear about which
handles are affected by it. This CL clarifies that it not only affects
the ones passed in AdditionalInheritedHandles, but also the ones
passed in ProcAttr.Files, which are required to be stderr, stdin and
stdout when calling syscall.StartProcess.

Updates #60942

Change-Id: I5bc5b3604b6db04b83f6764d5c5ffbdafeeb22fb
Reviewed-on: https://go-review.googlesource.com/c/go/+/505515
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/syscall/exec_windows.go