]> Cypherpunks repositories - gostls13.git/commit
math/cmplx: use signed zero to correct branch cuts
authorBrian Kessler <brian.m.kessler@gmail.com>
Fri, 23 Jun 2017 08:50:14 +0000 (01:50 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 27 Nov 2017 07:44:00 +0000 (07:44 +0000)
commit802a8f88a3e5e52de77cfb75a5926b2025d33f4f
tree7ce4b4c0b4a438235a50cb12f40edf644d40c5da
parent9dbeb92711b86ed4f0a37ad6ce465fb2d9053f2f
math/cmplx: use signed zero to correct branch cuts

Branch cuts for the elementary complex functions along real or imaginary axes
should be resolved in floating point calculations by one-sided continuity with
signed zero as described in:

"Branch Cuts for Complex Elementary Functions or Much Ado About Nothing's Sign Bit"
W. Kahan

Available at: https://people.freebsd.org/~das/kahan86branch.pdf

And as described in the C99 standard which is claimed as the original cephes source.

Sqrt did not return the correct branch when imag(x) == 0. The branch is now
determined by sign(imag(x)).  This incorrect branch choice was affecting the behavior
of the Trigonometric/Hyperbolic functions that use Sqrt in intermediate calculations.

Asin, Asinh and Atan had spurious domain checks, whereas the functions should be valid
over the whole complex plane with appropriate branch cuts.

Fixes #6888

Change-Id: I9b1278af54f54bfb4208276ae345bbd3ddf3ec83
Reviewed-on: https://go-review.googlesource.com/46492
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/math/cmplx/asin.go
src/math/cmplx/cmath_test.go
src/math/cmplx/sqrt.go