]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: improve documentation for ServerName.
authorAdam Langley <agl@golang.org>
Wed, 19 Feb 2014 16:17:09 +0000 (11:17 -0500)
committerAdam Langley <agl@golang.org>
Wed, 19 Feb 2014 16:17:09 +0000 (11:17 -0500)
commit80692a3f81f6367e9c61b652bf3dff30f4cc6624
treec041b1ffefd4c9b8cc51096c2566f32a099fe083
parentae38b03f6cab6a25f9d8d34a39e33db9857dce2e
crypto/tls: improve documentation for ServerName.

Users of the low-level, Client function are frequenctly missing the
fact that, unless they pass a ServerName to the TLS connection then it
cannot verify the certificates against any name.

This change makes it clear that at least one of InsecureSkipVerify and
ServerName should always be set.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/65440043
src/pkg/crypto/tls/common.go
src/pkg/crypto/tls/tls.go