]> Cypherpunks repositories - gostls13.git/commit
net/textproto: simplify common header interning
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 7 Apr 2014 17:39:24 +0000 (10:39 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 7 Apr 2014 17:39:24 +0000 (10:39 -0700)
commit8072f46abdf5b2d3ed0ee7d691823b7fcdaa7c21
tree0957d107cfa50303f01894879d03a2b4295a5cf5
parent24192bbd001385ca15ed1f769ddb467e41f4bf9c
net/textproto: simplify common header interning

Takes advantage of CL 83740044, to optimize map[string] lookup
from []byte key.

Deletes code.

No conditional check for gccgo, since Ian plans to add this
to gccgo before GCC 4.10 (Go 1.3).

benchmark                   old ns/op     new ns/op     delta
BenchmarkReadMIMEHeader     6066          5086          -16.16%

benchmark                   old allocs     new allocs     delta
BenchmarkReadMIMEHeader     12             12             +0.00%

benchmark                   old bytes     new bytes     delta
BenchmarkReadMIMEHeader     1317          1317          +0.00%

Update #3512

LGTM=rsc
R=rsc, dave
CC=golang-codereviews, iant
https://golang.org/cl/84230043
src/pkg/net/textproto/reader.go
src/pkg/net/textproto/reader_test.go