]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: add more non-ID comparisons to schedule
authorJosh Bleecher Snyder <josharian@gmail.com>
Thu, 23 Apr 2020 23:22:37 +0000 (16:22 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Fri, 24 Apr 2020 21:13:36 +0000 (21:13 +0000)
commit80ced393965eb74382c4df63e74461f0bf144c55
treeca2d12c4b6b7b07fc3bc5a0184e5eea81c8d7ed8
parent943a0d02d18bba5243f235fbbebd7f29d49d991e
cmd/compile: add more non-ID comparisons to schedule

These comparisons are fairly arbitrary,
but they should be more stable in the face
of other compiler changes than value ID.

This reduces the number of value ID
comparisons in schedule while running
make.bash from 542,442 to 99,703.

There are lots of changes to generated code
from this change, but they appear to
be overall neutral.

It is possible to further reduce the
number of comparisons in schedule;
I have changes locally that reduce the
number to about 25,000 during make.bash.
However, the changes are increasingly
complex and arcane, and reduce in much less
code churn. Given that the goal is stability,
that suggests that this is a reasonable
place to stop, at least for now.

Change-Id: Ie3a75f84fd3f3fdb102fcd0b29299950ea66b827
Reviewed-on: https://go-review.googlesource.com/c/go/+/229799
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/schedule.go