]> Cypherpunks repositories - gostls13.git/commit
os: ensure tests pass even if GOROOT is read-only
authorDiogo Pinela <diogoid7400@gmail.com>
Sun, 28 Oct 2018 17:29:29 +0000 (17:29 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sun, 28 Oct 2018 20:13:26 +0000 (20:13 +0000)
commit81475ca256df3fdd281c0e656b4e743caacbc4e0
treee19559ed9e7054fe1c587467f1805a93ed600138
parent3fe9d4c1c89f2a10e78780c421a2f5d93f218061
os: ensure tests pass even if GOROOT is read-only

We achieve this by always running all tests that create files in a
fresh temporary directory, rather than just on darwin/{arm,arm64}.
As a bonus, this lets us simplify the cleanup code for these tests
and assume their working directory starts out empty.

Updates #28387

Change-Id: I952007ae390a2451c9a368da26c7f9f5af64b2ba
Reviewed-on: https://go-review.googlesource.com/c/145283
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/os/os_test.go