]> Cypherpunks repositories - gostls13.git/commit
internal/trace: add task analysis for v2 traces
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 13 Nov 2023 21:06:40 +0000 (21:06 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 21 Nov 2023 21:28:47 +0000 (21:28 +0000)
commit816ee0be38a08b2636a1e870cb1dc1e9b27b742e
treed83765c59a2e72f853afc373e273028867646007
parent5dde69fd404cb6d0de89b0109a7f7b03e44c26f7
internal/trace: add task analysis for v2 traces

For v1 traces, cmd/trace contains code for analyzing tasks separately
from the goroutine analysis code present in internal/trace. As I started
to look into porting that code to v2 traces, I noticed that it wouldn't
be too hard to just generalize the existing v2 goroutine summary code to
generate exactly the same information.

This change does exactly that.

For #60773.
For #63960.

Change-Id: I0cdd9bf9ba11fb292a9ffc37dbf18c2a6a2483b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/542076
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/cmd/trace/v2/main.go
src/cmd/trace/v2/pprof.go
src/internal/trace/summary.go [moved from src/internal/trace/goroutinesv2.go with 85% similarity]
src/internal/trace/summary_test.go [moved from src/internal/trace/goroutinesv2_test.go with 59% similarity]
src/internal/trace/v2/testdata/mktests.go
src/internal/trace/v2/testdata/tests/go122-annotations-stress.test [new file with mode: 0644]