]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] cmd/compile: mark R16, R17 clobbered for non-standard calls...
authorCherry Zhang <cherryyz@google.com>
Fri, 28 Jun 2019 13:30:36 +0000 (09:30 -0400)
committerCarlos Amedee <carlos@golang.org>
Mon, 2 Aug 2021 22:28:48 +0000 (22:28 +0000)
commit818c5f6fbe136286b7c76f38a11929a60eb327bc
tree61b90959ec1b8d599716197cbb88ae3f88afcce3
parentb81d75fb42f3add3fefe7cf8fa220f88895920e5
[release-branch.go1.15] cmd/compile: mark R16, R17 clobbered for non-standard calls on ARM64

On ARM64, (external) linker generated trampoline may clobber R16
and R17. In CL 183842 we change Duff's devices not to use those
registers. However, this is not enough. The register allocator
also needs to know that these registers may be clobbered in any
calls that don't follow the standard Go calling convention. This
include Duff's devices and the write barrier.

Fixes #46927.
Updates #32773.

Change-Id: Ia52a891d9bbb8515c927617dd53aee5af5bd9aa4
Reviewed-on: https://go-review.googlesource.com/c/go/+/184437
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Meng Zhuo <mzh@golangcn.org>
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Meng Zhuo <mzh@golangcn.org>
(cherry picked from commit 11b4aee05bfe83513cf08f83091e5aef8b33e766)
Reviewed-on: https://go-review.googlesource.com/c/go/+/331030
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
src/cmd/compile/internal/ssa/gen/ARM64Ops.go
src/cmd/compile/internal/ssa/opGen.go
src/runtime/asm_arm64.s