]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/robustio: extend filesystem workarounds to darwin platforms
authorBryan C. Mills <bcmills@google.com>
Thu, 26 Sep 2019 14:22:26 +0000 (10:22 -0400)
committerBryan C. Mills <bcmills@google.com>
Thu, 26 Sep 2019 15:28:04 +0000 (15:28 +0000)
commit81c6bac06f5f8a45f0837cb42b2793df64de08a7
tree53bf83c99e4849190adda30d3237a4070a91639a
parent7defbffcdaa21037aa2ccccbbdaa6a8bc17cd057
cmd/go/internal/robustio: extend filesystem workarounds to darwin platforms

The macOS filesystem seems to have gotten significantly flakier as of
macOS 10.14, so this causes frequently flakes in the 10.14 builders.

We have no reason to believe that it will be fixed any time soon, so
rather than trying to detect the specific macOS version, we'll apply
the same workarounds that we use on Windows: classifying (and
retrying) the errors known to indicate flakiness and relaxing the
success criteria for renameio.TestConcurrentReadsAndWrites.

Fixes #33041

Change-Id: I74d8c15677951d7a0df0d4ebf6ea03e43eebddf9
Reviewed-on: https://go-review.googlesource.com/c/go/+/197517
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/renameio/renameio_test.go
src/cmd/go/internal/robustio/robustio_darwin.go [new file with mode: 0644]
src/cmd/go/internal/robustio/robustio_flaky.go [new file with mode: 0644]
src/cmd/go/internal/robustio/robustio_other.go
src/cmd/go/internal/robustio/robustio_windows.go