]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.22] crypto/tls: don't call tlsrsakex.IncNonDefault with FIPS
authorMike Beaumont <mjboamail@gmail.com>
Mon, 29 Apr 2024 10:14:32 +0000 (12:14 +0200)
committerJoedian Reid <joedian@google.com>
Mon, 24 Jun 2024 17:11:13 +0000 (17:11 +0000)
commit81fc6162675ea2543aa30ae35e56769c3d8a39ca
treeb6a85b254809aed00dccf08e3282c3dabc1586b2
parent14f0251867fbc400674333723e4d6e0dab122761
[release-branch.go1.22] crypto/tls: don't call tlsrsakex.IncNonDefault with FIPS

We haven't called tlsrsakex.Value() yet at this point if we're using
FIPS, like if CipherSuites != nil. This adds needFIPS as a gate next to
CipherSuites != nil. FIPS specifies suites that would be skipped if
tlsarsakex were set.

For #65991.
Fixes #65994.

Change-Id: I8070d8f43f27c04067490af8cc7ec5e787f2b9bd
Reviewed-on: https://go-review.googlesource.com/c/go/+/582315
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Bypass: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 78e50d0fa0bc78d197bd1b41e1bdef8c20a03396)
Reviewed-on: https://go-review.googlesource.com/c/go/+/593395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
src/crypto/tls/handshake_client.go
src/crypto/tls/handshake_server.go