]> Cypherpunks repositories - gostls13.git/commit
cmd/go: remove work directory on usage error
authorIan Lance Taylor <iant@golang.org>
Wed, 20 Feb 2019 23:15:18 +0000 (15:15 -0800)
committerIan Lance Taylor <iant@golang.org>
Fri, 1 Mar 2019 18:26:37 +0000 (18:26 +0000)
commit820ad17303e42665fbe9d38d79f07ed218e86302
treef22e49bd089a32e5ccbea50e10bc1bf9216c7471
parent7c388cc89c76bc7167287fb488afcaf5a4aa12bf
cmd/go: remove work directory on usage error

Ensure that cmd/go consistently calls base.Exit rather than os.Exit,
so that we don't incorrectly leave the work directory around on exit.

Test this by modifying the testsuite to run all the tests with TMPDIR
set to a temporary directory, and then check that no files are left
behind in that temporary directory. Adjust a couple of tests to make
this approach work.

Updates #30500
Updates https://gcc.gnu.org/PR89406

Change-Id: Ib6a5fc8a288a6cf4713022baa2b8dfefad62ba34
Reviewed-on: https://go-review.googlesource.com/c/163237
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/go_test.go
src/cmd/go/internal/base/base.go
src/cmd/go/internal/cmdflag/flag.go
src/cmd/go/internal/help/help.go
src/cmd/go/internal/vet/vetflag.go
src/cmd/go/internal/work/action.go
src/cmd/go/internal/work/exec.go
src/cmd/go/internal/work/gccgo.go
src/cmd/go/internal/work/init.go
src/cmd/go/script_test.go