]> Cypherpunks repositories - gostls13.git/commit
Revert "os/exec: avoid calling LookPath in cmd.Start for resolved paths"
authorIan Lance Taylor <iant@golang.org>
Tue, 12 Sep 2023 00:07:55 +0000 (00:07 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 12 Sep 2023 00:57:26 +0000 (00:57 +0000)
commit8221f90f1347bd96548d48b178c8bcb0607cde8f
treee8bf15b64d139b7e93a4d6b56e2c29f75501990b
parent06138963a2a16e0ac982ac85877092920a21e60f
Revert "os/exec: avoid calling LookPath in cmd.Start for resolved paths"

This reverts CL 512155.

Reason for revert: CL 512155 introduced a race in that it caused
cmd.Start to set cmd.Path. Previously it was fine if code looked
at cmd.Path in one goroutine while calling cmd.Start in a different
goroutine.

A test case for this race is in CL 527495.

Change-Id: Ic18fdadf6763727f8ea748280d5f0e601b9bf374
Reviewed-on: https://go-review.googlesource.com/c/go/+/527337
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/os/exec/exec.go
src/os/exec/lp_plan9.go
src/os/exec/lp_unix.go
src/os/exec/lp_wasm.go
src/os/exec/lp_windows.go