]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15-security] math/big: fix shift for recursive division
authorKatie Hockman <katie@golang.org>
Tue, 10 Nov 2020 20:54:12 +0000 (15:54 -0500)
committerKatie Hockman <katiehockman@google.com>
Wed, 11 Nov 2020 23:35:42 +0000 (23:35 +0000)
commit84150d0af193a7ccd733b3c7fa5787f43125cd2d
tree4a3a16d190157a2a9dc2cdbea151715ee665278d
parentec06b6d6be568ce1591d91a0ea4f14c190d06605
[release-branch.go1.15-security] math/big: fix shift for recursive division

The previous s value could cause a crash
for certain inputs.

Will check in tests and documentation improvements later.

Thanks to the Go Ethereum team and the OSS-Fuzz project for reporting this.
Thanks to Rémy Oudompheng and Robert Griesemer for their help
developing and validating the fix.

Fixes CVE-2020-28362

Change-Id: Ibbf455c4436bcdb07c84a34fa6551fb3422356d3
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/899974
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Reviewed-by: Filippo Valsorda <valsorda@google.com>
(cherry picked from commit 28015462c2a83239543dc2bef651e9a5f234b633)
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/901065
src/math/big/nat.go