]> Cypherpunks repositories - gostls13.git/commit
crypto/x509: return additional chains from Verify on Windows
authorKoen <me@koenspanjer.com>
Tue, 13 Oct 2020 23:05:43 +0000 (01:05 +0200)
committerFilippo Valsorda <filippo@golang.org>
Mon, 9 Nov 2020 18:32:41 +0000 (18:32 +0000)
commit858fa061aed447527fa5f451e7d611d8735f8cb6
treed6597c8a8b429c9c220b4832674f0ccdb91adc16
parent8a368c63ec2d48e1c8965341c982987de96164fd
crypto/x509: return additional chains from Verify on Windows

Previously windows only returned the certificate-chain with the highest quality.
This change makes it so chains with a potentially lower quality
originating from other root certificates are also returned by verify.

Tests in verify_test flagged with systemLax are now allowed to pass if the system returns additional chains

Fixes #40604

Change-Id: I66edc233219f581039d47a15f2200ff627154691
Reviewed-on: https://go-review.googlesource.com/c/go/+/257257
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/crypto/x509/root_windows.go
src/crypto/x509/verify_test.go