]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: search for remaining WB ops from end to beginning
authorJosh Bleecher Snyder <josharian@gmail.com>
Wed, 17 May 2017 13:28:03 +0000 (06:28 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Thu, 18 May 2017 20:14:12 +0000 (20:14 +0000)
commit85b2940f5c82e00ccc7f60ba2816cea0d418a950
tree5a00b466ec119e0d32314ee9b43134395eae8973
parent638ebb04f24b49a75211775d839f6cb557993a26
cmd/compile: search for remaining WB ops from end to beginning

The writebarrier pass processes WB ops from beginning to end,
replacing them by other values.
But it also checks whether there are more ops to process
by walking from beginning to end.
This is quadratic, so walk from end to beginning instead.

This speeds up compiling the code in issue 13554:

name  old time/op       new time/op       delta
Pkg         11.9s ± 2%         8.3s ± 3%  -29.88%  (p=0.000 n=18+17)

Updates #13554

Passes toolstash-check.

Change-Id: I5f8a872ddc4b783540220d89ea2ee188a6d2b2ff
Reviewed-on: https://go-review.googlesource.com/43571
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssa/writebarrier.go