]> Cypherpunks repositories - gostls13.git/commit
cmd/go: reject GOCACHE=off when the default cache is initialized
authorBryan C. Mills <bcmills@google.com>
Fri, 7 Dec 2018 17:05:00 +0000 (12:05 -0500)
committerBryan C. Mills <bcmills@google.com>
Wed, 12 Dec 2018 23:10:30 +0000 (23:10 +0000)
commit862ba63823e23202e50d7b756e37809c4eddf54b
tree857c255bcaacbd84592b5d77e52fa4ebe18a8b3d
parent3ae2c6c52eb4b8714245b91d094e0ccdfdbe585c
cmd/go: reject GOCACHE=off when the default cache is initialized

Allow GOCACHE=off only for operations that never actually write
anything to the cache (in which case the GOCACHE setting should not
matter at all).

Fixes #29127

Change-Id: I733d02cd2fbcf3671f5adcfb73522865d131e360
Reviewed-on: https://go-review.googlesource.com/c/153462
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
doc/go1.12.html
src/cmd/dist/test.go
src/cmd/go/go_test.go
src/cmd/go/internal/cache/default.go
src/cmd/go/internal/cache/default_unix_test.go [deleted file]
src/cmd/go/testdata/script/build_GOTMPDIR.txt
src/cmd/go/testdata/script/build_nocache.txt [new file with mode: 0644]
src/cmd/go/testdata/script/build_relative_pkgdir.txt [new file with mode: 0644]
src/cmd/go/testdata/script/build_relative_tmpdir.txt [new file with mode: 0644]
src/cmd/go/testdata/script/cache_unix.txt [new file with mode: 0644]