]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix go get fail when GIT_TRACE set
authorLE Manh Cuong <cuong.manhle.vn@gmail.com>
Mon, 30 Jul 2018 18:11:32 +0000 (01:11 +0700)
committerBryan C. Mills <bcmills@google.com>
Mon, 6 Aug 2018 14:12:24 +0000 (14:12 +0000)
commit870e12d7bfaea70fb0d743842f5864eb059cb939
tree2c8603f9adff6ffcd79e50d4d93f5298bcf8ad37
parent5a720d229d5ebc2f8b599aa54a3d807a1d54365f
cmd/go: fix go get fail when GIT_TRACE set

GIT_TRACE write message to stderr, while run1 merge both stdout and
stderr. So function which call run1 and rely on its output will failed
to parse the result when run1 success.

By using cmd.Output(), we ensure only cmd standard out is returned.

Fixes #19682

Change-Id: I7002df17fe68aea1860ddc7382c68cc23548bd90
Reviewed-on: https://go-review.googlesource.com/126735
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/go/internal/get/vcs.go
src/cmd/go/testdata/script/get_with_git_trace.txt [new file with mode: 0644]