]> Cypherpunks repositories - gostls13.git/commit
runtime: call runtime.GC in several tests that disable GC
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 6 Dec 2021 22:35:58 +0000 (17:35 -0500)
committerMichael Knyszek <mknyszek@google.com>
Mon, 6 Dec 2021 23:02:28 +0000 (23:02 +0000)
commit871d63fb73476bc3bf52ceec9aa8bef3ffc85d51
treec2a7e1ec6f0128e3debac85c3bdd44edc60fb8c6
parent8ea0ffb84a5807438061d34256448df9948a3809
runtime: call runtime.GC in several tests that disable GC

These tests disable GC because of the potential for a deadlock, but
don't consider that a GC could be in progress due to other tests. The
likelihood of this case was increased when the minimum heap size was
lowered during the Go 1.18 cycle. The issue was then mitigated by
CL 368137 but in theory is always a problem.

This change is intended specifically for #45867, but I just walked over
a whole bunch of other tests that don't take this precaution where it
seems like it could be relevant (some tests it's not, like the
UserForcedGC test, or testprogs where no other code has run before it).

Fixes #45867.

Change-Id: I6a1b4ae73e05cab5a0b2d2cce14126bd13be0ba5
Reviewed-on: https://go-review.googlesource.com/c/go/+/369747
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: David Chase <drchase@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/proc_test.go
src/runtime/testdata/testprog/badtraceback.go
src/runtime/testdata/testprog/preempt.go