]> Cypherpunks repositories - gostls13.git/commit
go/internal/gcimporter: propagate errors from FindPkg
authorBryan C. Mills <bcmills@google.com>
Thu, 29 Jun 2023 19:22:32 +0000 (15:22 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 20 Jul 2023 21:23:25 +0000 (21:23 +0000)
commit884aa71f5126d10f7fa4cbf2dd643b3595763908
tree36527353a6515b133b690fec27d4d9bb34d2f0db
parent7b625d1f65a6224968d8668c1ae1b0730dabb605
go/internal/gcimporter: propagate errors from FindPkg

Previously, FindPkg returned the empty string as a sentinel value,
causing Import to collapse all errors to "can't find import".

(See also https://go.dev/wiki/CodeReviewComments#in-band-errors.)

For #61064.

Change-Id: I21f335d206308b44fe585619e00782abb0b65a94
Reviewed-on: https://go-review.googlesource.com/c/go/+/507360
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
src/cmd/compile/internal/importer/gcimporter.go
src/cmd/compile/internal/importer/gcimporter_test.go
src/go/internal/gcimporter/gcimporter.go
src/go/internal/gcimporter/gcimporter_test.go