]> Cypherpunks repositories - gostls13.git/commit
cmd/go: remove a bogus assertion in mod_convert_dep
authorBryan C. Mills <bcmills@google.com>
Sat, 6 Jun 2020 02:35:18 +0000 (22:35 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 8 Jun 2020 19:02:07 +0000 (19:02 +0000)
commit8891b82332de4afa23f935b58263d08a3a5c6d95
tree3ed904ec347ef4f2d25fcd7f81718b7254873546
parent2603d9a89ae1eb06386b9dd68fdb9f185aca4804
cmd/go: remove a bogus assertion in mod_convert_dep

The removed line assumed that the script's WORK directory is not a
child of any directory containing version-control metadata.
While that assumption does hold in most cases, it does not hold when,
for example, $TMPDIR is $HOME/tmp and $HOME/.git/config exists.

A similar situation may or may not arise when using
golang.org/x/build/cmd/release. Either way, the assertion is incorrect
and was interfering with local testing for #39385.

Updates #39385
Fixes #39431

Change-Id: I67813d7ce455aa9b56a6eace6eddebf48d0f7fa6
Reviewed-on: https://go-review.googlesource.com/c/go/+/236818
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/go/testdata/script/mod_convert_dep.txt