]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: disallow typed non-integer constant len and cap make arguments
authorMartin Möhrmann <martisch@uos.de>
Thu, 1 Sep 2016 06:31:37 +0000 (08:31 +0200)
committerMartin Möhrmann <martisch@uos.de>
Thu, 1 Sep 2016 20:29:03 +0000 (20:29 +0000)
commit8895a99c9ff522cf41f3a1bee365bd0c7e0c7900
treebc569c569e3ea307502085b12035f7ff6108c87b
parent809bb3a71c2cdceb93c349888b186787589d5ec7
cmd/compile: disallow typed non-integer constant len and cap make arguments

make(T, n, m) returns a slice of type T with length n and capacity m
where "The size arguments n and m must be of integer type or untyped."
https://tip.golang.org/ref/spec#Making_slices_maps_and_channels

The failure to reject typed non-integer size arguments in make
during compile time was uncovered after https://golang.org/cl/27851
changed the generation of makeslice calls.

Fixes   #16940
Updates #16949

Change-Id: Ib1e3576f0e6ad199c9b16b7a50c2db81290c63b4
Reviewed-on: https://go-review.googlesource.com/28301
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/gc/typecheck.go
test/fixedbugs/issue16949.go [new file with mode: 0644]