]> Cypherpunks repositories - gostls13.git/commit
[dev.cc] cmd/asm: changes to get identical output as new6a
authorRob Pike <r@golang.org>
Fri, 23 Jan 2015 19:24:42 +0000 (11:24 -0800)
committerRob Pike <r@golang.org>
Sat, 24 Jan 2015 03:28:26 +0000 (03:28 +0000)
commit89162307cd2ddf0a514d3a3ed9f7b94e45f1cb15
treeceff0b5c05581907f57c1b4701ae0a71ddc2965c
parent07a27ce09ea01c1939389d5f5e1d3414fc893882
[dev.cc] cmd/asm: changes to get identical output as new6a

Fix up a couple of minor things pointed out in the last review.
Also:

1. If the symbol starts with center dot, prefix the name with "".
2. If there is no locals size specified, use ArgsSizeUnknown (sic).
3. Do not emit a history point at the start of a macro invocation,
since we do not pop it at the end, behavior consistent with the
old code.

With these changes, old and new assemblers produce identical
output at least for my simple test case, so that provides a verifiable
check for future cleanups.

Change-Id: Iaa91d8e453109824b4be44321ec5e828f39f0299
Reviewed-on: https://go-review.googlesource.com/3242
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/asm/internal/asm/asm.go
src/cmd/asm/internal/lex/input.go
src/cmd/asm/internal/lex/lex.go
src/cmd/asm/internal/lex/tokenizer.go
src/cmd/asm/main.go