]> Cypherpunks repositories - gostls13.git/commit
net/http/httptest: don't panic on Close of user-constructed Server value
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 27 Mar 2017 16:32:04 +0000 (16:32 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 27 Mar 2017 17:01:57 +0000 (17:01 +0000)
commit89ebe5bbca0638567771cb2b0376b059122a77ba
tree487893cb37912ec4667eef51144f7ca7d13a05d2
parent4234d1decd853b2373c17340eb4c0033c0fe9566
net/http/httptest: don't panic on Close of user-constructed Server value

If the user created an httptest.Server directly without using a
constructor it won't have the new unexported 'client' field. So don't
assume it's non-nil.

Fixes #19729

Change-Id: Ie92e5da66cf4e7fb8d95f3ad0f4e3987d3ae8b77
Reviewed-on: https://go-review.googlesource.com/38710
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Kevin Burke <kev@inburke.com>
src/net/http/httptest/server.go
src/net/http/httptest/server_test.go