]> Cypherpunks repositories - gostls13.git/commit
cmd/go: revert multi-flag GOFLAGS doc example
authorDaniel Martí <mvdan@mvdan.cc>
Tue, 4 Dec 2018 16:25:39 +0000 (16:25 +0000)
committerDaniel Martí <mvdan@mvdan.cc>
Tue, 4 Dec 2018 22:19:57 +0000 (22:19 +0000)
commit8a5797a00e0bbe483e88aab4830e8854af55b508
tree99cdb67cf5ed238a2d2b9e16f589bcdf4bd8b753
parentbcd3385ed6fb4e9ea3b25798a542427486972967
cmd/go: revert multi-flag GOFLAGS doc example

This partially reverts https://golang.org/cl/135035.

Reason for revert: multiple -ldflags=-foo flags simply override each
other, since that's the logic for per-package flags. The suggested
'GOFLAGS=-ldflags=-s -ldflags=-w' has never worked for 'go build', and
even breaks 'go test' and 'go vet'.

There should be a way to specify -ldflags='-w -s' via GOFLAGS, which is
being tracked in #29096. For now, just remove the incorrect suggestion.

Fixes #29053.

Change-Id: I9203056f7e5191e894bcd16595a92df2fb704ea7
Reviewed-on: https://go-review.googlesource.com/c/152479
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
src/cmd/go/alldocs.go
src/cmd/go/internal/help/helpdoc.go