]> Cypherpunks repositories - gostls13.git/commit
runtime: ready scavenger without next
authorMichael Anthony Knyszek <mknyszek@google.com>
Fri, 22 Nov 2019 21:06:15 +0000 (21:06 +0000)
committerMichael Knyszek <mknyszek@google.com>
Wed, 27 Nov 2019 23:14:19 +0000 (23:14 +0000)
commit8a5af7910a9b157c02736c3e0998a587bb8511c1
treee1b5e9df3c1ff5056f90b843e5b9bbaff3ff21de
parent9174e2c03c423a47bf052b8a1aa844f3378eccd4
runtime: ready scavenger without next

This change makes it so that waking up the scavenger readies its
goroutine without "next" set, so that it doesn't interfere with the
application's use of the runnext feature in the scheduler which helps
fairness.

As of CL 201763 the scavenger began waking up much more often, and in
TestPingPongHog this meant that it would sometimes supercede either a
hog or light goroutine in runnext, leading to a skew in the results and
ultimately a test flake.

This change thus re-enables the TestPingPongHog test on the builders.

Fixes #35271.

Change-Id: Iace08576912e8940554dd7de6447e458ad0d201d
Reviewed-on: https://go-review.googlesource.com/c/go/+/208380
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/runtime/mgcscavenge.go
src/runtime/proc_test.go