]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: fix computation of test timeout
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 4 May 2018 05:32:01 +0000 (05:32 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 4 May 2018 17:01:04 +0000 (17:01 +0000)
commit8aa316c13973bae7693a8710d69a6ec452e490a1
treeb0e90d11d90f1f1c05cc060547ebb1ee9f8ef887
parentbcdbd58ce48d71cb912238caaa193d832901e227
cmd/dist: fix computation of test timeout

When dist test was updated to run "go test" with multiple package
arguments at once, merging the logical test units into one execution,
the hack to give cmd/go twice as much time wasn't updated.

What was happening (even in the all.bash case) was that we were
merging together, say, "cmd/go" and "bytes", and because bar was
lexically earlier, the timeout calculation was based on package "byte",
even though we were actually running, say: "go test bytes cmd/go".

This explains why x/build/cmd/release was often flaky with its
all.bash, since cmd/go can't really finish in 3 minutes reliably
unless it's running by itself. If it has any competition, it runs
over.

Change-Id: I875c8c9e65940ce0ceff48215740dfadfaa89d3f
Reviewed-on: https://go-review.googlesource.com/111395
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
src/cmd/dist/test.go