]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/gc: remove namebuf variable
authorMatthew Dempsky <mdempsky@google.com>
Fri, 6 Mar 2015 20:02:24 +0000 (12:02 -0800)
committerIan Lance Taylor <iant@golang.org>
Fri, 13 Mar 2015 23:35:11 +0000 (23:35 +0000)
commit8b3670ffc6491ee54245e27f99b2415fbb1287d5
tree57ea070378b77b39ad15297297ea2fc65b0fb1ca
parent211df1de124feb20219b77ddf3e8ba6d392bdfb5
cmd/internal/gc: remove namebuf variable

namebuf was a global char buffer in the C version of gc, which was
useful for providing common storage for constructing symbol and file
names.  However, now that it's just a global Go string and the string
data is dynamically allocated anyway, it doesn't serve any purpose
except to force extra write barriers everytime it's assigned to.

Also, introduce Lookupf(fmt, args...) as shorthand for
Lookup(fmt.Sprintf(fmt, args...)), which was a very common pattern for
using namebuf.

Passes "go build -toolexec 'toolstash -cmp' -a std".

Notably, this CL shrinks 6g's text section by ~15kB:

$ size toolstash/6g tool/linux_amd64/6g
   text    data     bss     dec     hex filename
4600805  605968  342988 5549761  54aec1 toolstash/6g
4585547  605968  342956 5534471  547307 tool/linux_amd64/6g

Change-Id: I98abb44fc7f43a2e2e48425cc9f215cd0be37442
Reviewed-on: https://go-review.googlesource.com/7080
Reviewed-by: Ian Lance Taylor <iant@golang.org>
12 files changed:
src/cmd/internal/gc/closure.go
src/cmd/internal/gc/dcl.go
src/cmd/internal/gc/gen.go
src/cmd/internal/gc/go.go
src/cmd/internal/gc/init.go
src/cmd/internal/gc/inl.go
src/cmd/internal/gc/lex.go
src/cmd/internal/gc/obj.go
src/cmd/internal/gc/pgen.go
src/cmd/internal/gc/sinit.go
src/cmd/internal/gc/subr.go
src/cmd/internal/gc/walk.go