]> Cypherpunks repositories - gostls13.git/commit
internal/trace: merge event and tracev2 packages
authorMichael Anthony Knyszek <mknyszek@google.com>
Wed, 29 Jan 2025 17:16:02 +0000 (17:16 +0000)
committerGopher Robot <gobot@golang.org>
Mon, 10 Feb 2025 20:14:51 +0000 (12:14 -0800)
commit8b8ab2584d52c96ed84207208f13a37272cab217
treef2156e52205cec22a4d24a20948860bafde13968
parent9faa00af74206dfc26c3d38cd56590abc4b2b960
internal/trace: merge event and tracev2 packages

These two packages were historically separate in an attempt to provide a
unified description of trace v1 and trace v2 formats. In practice this
turned out to be pointless, since it made more sense to keep the trace
v1 parser in a self-contained bubble with a converter to v2. Future
trace wire format migrations should probably just follow the same
general strategy, if there's a substantial change. (Minor changes can be
handled more organically.)

Change-Id: Ic765df62065fe53cfae59b505297527c3fa42dfb
Reviewed-on: https://go-review.googlesource.com/c/go/+/645395
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
18 files changed:
src/cmd/trace/main.go
src/go/build/deps_test.go
src/internal/trace/base.go
src/internal/trace/batch.go
src/internal/trace/batchcursor.go
src/internal/trace/event.go
src/internal/trace/generation.go
src/internal/trace/internal/testgen/trace.go
src/internal/trace/internal/tracev1/parser.go
src/internal/trace/order.go
src/internal/trace/raw/event.go
src/internal/trace/raw/reader.go
src/internal/trace/raw/textreader.go
src/internal/trace/raw/writer.go
src/internal/trace/tracev1.go
src/internal/trace/tracev2/events.go [moved from src/internal/trace/tracev2/event.go with 86% similarity]
src/internal/trace/tracev2/spec.go [moved from src/internal/trace/tracev2/event/event.go with 84% similarity]
src/internal/trace/version/version.go