]> Cypherpunks repositories - gostls13.git/commit
cmd/go: support -modcacherw in 'go mod' subcommands
authorJay Conrod <jayconrod@google.com>
Tue, 22 Oct 2019 18:45:31 +0000 (14:45 -0400)
committerJay Conrod <jayconrod@google.com>
Tue, 22 Oct 2019 20:00:03 +0000 (20:00 +0000)
commit8ba43eaad8263f26e16846e345389146ec234364
tree9b4e1b44e4ed4b2014db4a1fad9ee6426b4041cc
parent88186e5e232625f9c91d639e0cb90a88c6cf1172
cmd/go: support -modcacherw in 'go mod' subcommands

The -modcacherw flag is now registered in work.AddModCommonFlags,
which is called from work.AddBuildFlags, where it was registered
before. 'go mod' subcommands register the flag by calling
work.AddModCommonFlags directly.

Also, build commands now exit with an error if -modcacherw is set
explicitly (not in GOFLAGS) in GOPATH mode.

Updates #31481

Change-Id: I461e59a51ed31b006fff4d5c57c2a866be0bbf38
Reviewed-on: https://go-review.googlesource.com/c/go/+/202563
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
14 files changed:
src/cmd/go/internal/cfg/cfg.go
src/cmd/go/internal/get/get.go
src/cmd/go/internal/modcmd/download.go
src/cmd/go/internal/modcmd/edit.go
src/cmd/go/internal/modcmd/graph.go
src/cmd/go/internal/modcmd/init.go
src/cmd/go/internal/modcmd/tidy.go
src/cmd/go/internal/modcmd/vendor.go
src/cmd/go/internal/modcmd/verify.go
src/cmd/go/internal/modcmd/why.go
src/cmd/go/internal/modfetch/fetch.go
src/cmd/go/internal/work/build.go
src/cmd/go/internal/work/init.go
src/cmd/go/testdata/script/mod_cache_rw.txt