]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types2: better error position for instantiation failure
authorRobert Griesemer <gri@golang.org>
Tue, 23 Nov 2021 21:54:02 +0000 (13:54 -0800)
committerRobert Griesemer <gri@golang.org>
Wed, 24 Nov 2021 21:11:34 +0000 (21:11 +0000)
commit8cdfe408bbd608c5129036e40f346d526049ffc4
treeba79a11310dbe13b7db674e79f7b0d2472f575e6
parent7e5331ac445045a70256eeeef5b7aad43886c9ec
cmd/compile/internal/types2: better error position for instantiation failure

- Thread type argument expressions (rather than posLists) through various
type-checker functions so we can provide a better error position.

- Adjust signatures that expect a syntax.Pos to accept a poser instead
to avoid gratuituous conversions from expressions to positions.

- Rename targsx to xlist so we use xlist consistently for expression
lists.

First step in providing a better error message for the issue below.

For #49179.

Change-Id: I8fc685a2ee4f5640f4abd35568ba32bcb34e9e84
Reviewed-on: https://go-review.googlesource.com/c/go/+/366757
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/builtins.go
src/cmd/compile/internal/types2/call.go
src/cmd/compile/internal/types2/mono.go
src/cmd/compile/internal/types2/testdata/fixedbugs/issue39754.go2
src/cmd/compile/internal/types2/testdata/fixedbugs/issue49179.go2 [new file with mode: 0644]
src/cmd/compile/internal/types2/typexpr.go