]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: lazily initialize litbuf
authorMatthew Dempsky <mdempsky@google.com>
Tue, 26 Apr 2016 17:55:32 +0000 (10:55 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 26 Apr 2016 22:49:54 +0000 (22:49 +0000)
commit8d075beeef137455b9dc40f1c724b495f3ceda26
tree4585b6e3eb667f701ef0248f7a518f568e2ba1f2
parent19912e1d0a0739cd8a3214de994f7e9ecb656e1d
cmd/compile: lazily initialize litbuf

Instead of eagerly creating strings like "literal 2.01" for every
lexed number in case we need to mention it in an error message, defer
this work to (*parser).syntax_error.

name      old allocs/op  new allocs/op  delta
Template      482k ± 0%      482k ± 0%  -0.12%   (p=0.000 n=9+10)
GoTypes      1.35M ± 0%     1.35M ± 0%  -0.04%  (p=0.015 n=10+10)
Compiler     5.45M ± 0%     5.44M ± 0%  -0.12%    (p=0.000 n=9+8)

Change-Id: I333b3c80e583864914412fb38f8c0b7f1d8c8821
Reviewed-on: https://go-review.googlesource.com/22480
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/gc/lex.go
src/cmd/compile/internal/gc/parser.go