]> Cypherpunks repositories - gostls13.git/commit
runtime: raise alert threshold on window smhasher test
authorKeith Randall <khr@golang.org>
Fri, 12 Jun 2020 18:07:56 +0000 (11:07 -0700)
committerKeith Randall <khr@golang.org>
Fri, 12 Jun 2020 20:46:27 +0000 (20:46 +0000)
commit8dae5390cbc2b4d3b772b8f17182e885523b698b
tree7680a16230c94dbe8cba699a6c9c63b1ae151fec
parent7d975ae9c04ca7e1c605ac051a13a4d5ff99fca3
runtime: raise alert threshold on window smhasher test

This alert is triggering occasionally. I've investigated the
collisions that happen, and they all seem to be pairwise, so they are
not a big deal.  "pairwise" = when there are 32 collisions, it is two
keys mapping to the same hash, 32 times, not 33 keys all mapping to
the same hash.

Add some t.Logf calls in case this comes back, which will help isolate
the problem.

Fixes #39352

Change-Id: I1749d7c8efd0afcf9024d8964d15bc0f58a86e4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/237718
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/runtime/hash_test.go